darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 16:31:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make sure we check if a service can send to number harmoniously

Browse Source 
We were checking this separately in two places in the code. Now
we will have this logic in one place, in validators.

Also pull in utils version that recognises crown depenency numbers
as international.
This commit is contained in:
Pea Tyczynska
2020-06-16 17:55:02 +01:00
parent b0bb0b9780
commit ef9f3c1e5f
6 changed files with 52 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/notifications/test_process_notification.py
View File

@@ -356,7 +356,7 @@ def test_simulated_recipient(notify_api, to_address, notification_type, expected
@pytest.mark.parametrize('recipient, expected_international, expected_prefix, expected_units', [
('7900900123', False, '44', 1), # UK
('+447900900123', False, '44', 1), # UK
('07700900222', False, '44', 1), # UK
('07700900222', True, '44', 1), # UK (Jersey)
('73122345678', True, '7', 1), # Russia
('360623400400', True, '36', 3)] # Hungary
)