darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-20 14:29:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Bump utils to version 56.0.0

Browse Source 
The only impactful change is the major version itself, where I've
fixed the breaking changes due to the upgrade of PyPDF2 [^1] and
checked there are no deprecation warnings when I run the tests.

[^1]: https://github.com/alphagov/notifications-utils/pull/973
This commit is contained in:
Ben Thorner
2022-06-01 13:40:29 +01:00
parent 6495b192a6
commit ee8e86f409
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/template/rest.py
View File

@@ -9,7 +9,7 @@ from notifications_utils.template import (
BroadcastMessageTemplate, BroadcastMessageTemplate,
SMSMessageTemplate, SMSMessageTemplate,
) )
from PyPDF2.utils import PdfReadError from PyPDF2.errors import PdfReadError
from requests import post as requests_post from requests import post as requests_post
from sqlalchemy.orm.exc import NoResultFound from sqlalchemy.orm.exc import NoResultFound

2
requirements.in
View File

@@ -29,7 +29,7 @@ notifications-python-client==6.3.0
# PaaS # PaaS
awscli-cwlogs==1.4.6 awscli-cwlogs==1.4.6
notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@55.1.6 notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@56.0.0
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.14.1 prometheus-client==0.14.1

6
requirements.txt
View File

@@ -160,7 +160,7 @@ mistune==0.8.4
# via notifications-utils # via notifications-utils
notifications-python-client==6.3.0 notifications-python-client==6.3.0
# via -r requirements.in # via -r requirements.in
notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@55.1.6 notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@56.0.0
# via -r requirements.in # via -r requirements.in
orderedset==2.0.3 orderedset==2.0.3
# via notifications-utils # via notifications-utils
@@ -189,7 +189,7 @@ pyjwt==2.4.0
# notifications-python-client # notifications-python-client
pyparsing==3.0.9 pyparsing==3.0.9
# via packaging # via packaging
pypdf2==1.28.2 pypdf2==2.0.0
# via notifications-utils # via notifications-utils
pyproj==3.3.1 pyproj==3.3.1
# via notifications-utils # via notifications-utils
@@ -250,6 +250,8 @@ sqlalchemy==1.4.36
# marshmallow-sqlalchemy # marshmallow-sqlalchemy
statsd==3.3.0 statsd==3.3.0
# via notifications-utils # via notifications-utils
typing-extensions==4.2.0
# via pypdf2
uri-template==1.2.0 uri-template==1.2.0
# via jsonschema # via jsonschema
urllib3==1.26.9 urllib3==1.26.9

2
tests/app/template/test_rest.py
View File

@@ -10,7 +10,7 @@ import pytest
import requests_mock import requests_mock
from freezegun import freeze_time from freezegun import freeze_time
from notifications_utils import SMS_CHAR_COUNT_LIMIT from notifications_utils import SMS_CHAR_COUNT_LIMIT
from PyPDF2.utils import PdfReadError from PyPDF2.errors import PdfReadError
from app.dao.templates_dao import ( from app.dao.templates_dao import (
dao_get_template_by_id, dao_get_template_by_id,