Fix sending emails with no logo

Code was not expecting logo to be `None`, thereby causing the task to
throw an exception, and retry until eventually putting the email in
technical error (for services with org branding but no logo).
This commit is contained in:
Chris Hill-Scott
2017-09-21 13:37:57 +01:00
parent 8360b9a122
commit ee5888f07f
2 changed files with 14 additions and 1 deletions

View File

@@ -179,10 +179,11 @@ def get_html_email_options(service):
govuk_banner = service.branding not in (BRANDING_ORG, BRANDING_ORG_BANNER)
brand_banner = service.branding == BRANDING_ORG_BANNER
if service.organisation and service.branding != BRANDING_GOVUK:
logo_url = get_logo_url(
current_app.config['ADMIN_BASE_URL'],
service.organisation.logo
)
) if service.organisation.logo else None
branding = {
'brand_colour': service.organisation.colour,