diff --git a/app/letters/letter_schemas.py b/app/letters/letter_schemas.py index 9a4d28958..fdce5b3b5 100644 --- a/app/letters/letter_schemas.py +++ b/app/letters/letter_schemas.py @@ -1,20 +1,3 @@ -from app.schema_validation.definitions import uuid - -letter_job_ids = { - "$schema": "http://json-schema.org/draft-04/schema#", - "description": "list of job ids", - "type": "object", - "title": "job_ids", - "properties": { - "job_ids": {"type": "array", - "items": uuid, - "minItems": 1 - }, - }, - "required": ["job_ids"] -} - - letter_references = { "$schema": "http://json-schema.org/draft-04/schema#", "description": "list of letter notification references", diff --git a/tests/app/letters/test_letter_schemas.py b/tests/app/letters/test_letter_schemas.py deleted file mode 100644 index af64106a3..000000000 --- a/tests/app/letters/test_letter_schemas.py +++ /dev/null @@ -1,30 +0,0 @@ -import json -import uuid - -import pytest -from jsonschema import ValidationError - -from app.letters.letter_schemas import letter_job_ids -from app.schema_validation import validate - - -def test_letter_job_id_retuns_400_if_array_is_empty(): - with pytest.raises(ValidationError) as e: - validate({"job_ids": []}, letter_job_ids) - error = json.loads(str(e.value)) - assert len(error.keys()) == 2 - assert error.get('errors')[0]['message'] == 'job_ids [] is too short' - - -def test_letter_job_id_retuns_400_if_array_doesnot_contain_uuids(): - with pytest.raises(ValidationError) as e: - validate({"job_ids": ["1", "2"]}, letter_job_ids) - error = json.loads(str(e.value)) - assert len(error.keys()) == 2 - assert error.get('errors')[0]['message'] == 'job_ids is not a valid UUID' - - -def test_letter_job(): - ids_ = {"job_ids": [str(uuid.uuid4()), str(uuid.uuid4())]} - j = validate(ids_, letter_job_ids) - assert j == ids_