From ed9936bba03dd1a3014644489e9e10285870c7f6 Mon Sep 17 00:00:00 2001 From: Richard Chapman Date: Tue, 6 Mar 2018 14:42:53 +0000 Subject: [PATCH] Fixed bug where the content header was not being passed onto the post request. Changed data => json. Added extra logging to display the error with more detail --- app/template/rest.py | 2 +- tests/app/template/test_rest.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/template/rest.py b/app/template/rest.py index 22f3295c9..c938b2ea6 100644 --- a/app/template/rest.py +++ b/app/template/rest.py @@ -266,7 +266,7 @@ def _get_png_preview(url, data, notification_id): resp.content )) raise InvalidRequest( - 'Error generating preview letter for {} \nStatus code: {}\n{}'.format( + 'Error generating preview letter for {}\nStatus code: {}\n{}'.format( notification_id, resp.status_code, resp.content diff --git a/tests/app/template/test_rest.py b/tests/app/template/test_rest.py index 14e0aba55..99889e238 100644 --- a/tests/app/template/test_rest.py +++ b/tests/app/template/test_rest.py @@ -874,7 +874,9 @@ def test_preview_letter_template_by_id_template_preview_500( _expected_status=500 ) - assert resp['message'] == 'Error generating preview for {}'.format(sample_letter_notification.id) + assert 'Status code: 404' in resp['message'] + assert 'Error generating preview letter for {}'.format(sample_letter_notification.id) in resp['message'] + def test_preview_letter_template_precompiled_pdf_file_type(