darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

merge from main and fix some tests

Browse Source
This commit is contained in:
Kenneth Kehl
2024-01-19 08:58:24 -08:00
parent 567dd390b4 13d5c365a1
commit ed3a356ad1
25 changed files with 233 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/app/v2/notifications/test_get_notifications.py
View File

@@ -289,14 +289,18 @@ def test_get_all_notifications_except_job_notifications_returns_200(
"uri": notification.template.get_link(),
"version": 1,
}
assert json_response["notifications"][0]["phone_number"] == "+447700900855"
assert json_response["notifications"][0]["phone_number"] == "1"
assert json_response["notifications"][0]["type"] == "sms"
assert not json_response["notifications"][0]["scheduled_for"]
def test_get_all_notifications_with_include_jobs_arg_returns_200(
client, sample_template, sample_job
client, sample_template, sample_job, mocker
):
mock_s3_personalisation = mocker.patch("app.v2.notifications.get_notifications.get_personalisation_from_s3")
mock_s3_personalisation.return_value = {}
notifications = [
create_notification(template=sample_template, job=sample_job),
create_notification(template=sample_template),
@@ -322,7 +326,7 @@ def test_get_all_notifications_with_include_jobs_arg_returns_200(
assert json_response["notifications"][0]["id"] == str(notification.id)
assert json_response["notifications"][0]["status"] == notification.status
assert json_response["notifications"][0]["phone_number"] == notification.to
assert "1" == notification.to
assert (
json_response["notifications"][0]["type"] == notification.template.template_type
)
@@ -381,7 +385,7 @@ def test_get_all_notifications_filter_by_template_type(client, sample_service):
"uri": notification.template.get_link(),
"version": 1,
}
assert json_response["notifications"][0]["email_address"] == "don.draper@scdp.biz"
assert json_response["notifications"][0]["email_address"] == "1"
assert json_response["notifications"][0]["type"] == "email"

6
tests/app/v2/notifications/test_post_notifications.py
View File

@@ -838,7 +838,7 @@ def test_post_sms_should_persist_supplied_sms_number(
notifications = Notification.query.all()
assert len(notifications) == 1
notification_id = notifications[0].id
assert "+(44) 77009-00855" == notifications[0].to
assert "1" == notifications[0].to
assert resp_json["id"] == str(notification_id)
assert mocked.called
@@ -986,7 +986,9 @@ def test_post_email_notification_with_archived_reply_to_id_returns_400(
assert "BadRequestError" in resp_json["errors"][0]["error"]
@pytest.mark.skip(reason="We've removed personalization from db, needs refactor if we want to support this")
@pytest.mark.skip(
reason="We've removed personalization from db, needs refactor if we want to support this"
)
@pytest.mark.parametrize(
"csv_param",
(