Merge pull request #1041 from alphagov/send-notification-fix

ensure created_by_id is being persisted correctly

app/models.py

@@ -1007,6 +1007,9 @@ class NotificationHistory(db.Model, HistoryModel):
     phone_prefix = db.Column(db.String, nullable=True)
     rate_multiplier = db.Column(db.Float(asdecimal=False), nullable=True)
 
+    created_by = db.relationship('User')
+    created_by_id = db.Column(UUID(as_uuid=True), db.ForeignKey('users.id'), nullable=True)
+
     @classmethod
     def from_original(cls, notification):
         history = super().from_original(notification)

app/notifications/process_notifications.py

@@ -52,7 +52,6 @@ def persist_notification(
     simulated=False,
     created_by_id=None
 ):
-
     notification_created_at = created_at or datetime.utcnow()
 
     notification = Notification(
@@ -70,7 +69,8 @@ def persist_notification(
         job_id=job_id,
         job_row_number=job_row_number,
         client_reference=client_reference,
-        reference=reference
+        reference=reference,
+        created_by_id=created_by_id
     )
 
     if notification_type == SMS_TYPE: