darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-06 10:18:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #777 from GSA/main

Browse Source 
CSV error handling prod deploy
This commit is contained in:
Carlo Costino
2024-01-31 11:37:54 -05:00
committed by GitHub
parent 7f36b6c3a1 11cace732a
commit ec388f95f2
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/aws/s3.py
View File

@@ -84,7 +84,7 @@ def incr_jobs_cache_misses():
redis_store.incr(JOBS_CACHE_MISSES) redis_store.incr(JOBS_CACHE_MISSES)
hits = redis_store.get(JOBS_CACHE_HITS).decode("utf-8") hits = redis_store.get(JOBS_CACHE_HITS).decode("utf-8")
misses = redis_store.get(JOBS_CACHE_MISSES).decode("utf-8") misses = redis_store.get(JOBS_CACHE_MISSES).decode("utf-8")
current_app.logger.info(f"JOBS CACHE MISS hits {hits} misses {misses}") current_app.logger.debug(f"JOBS CACHE MISS hits {hits} misses {misses}")
def incr_jobs_cache_hits(): def incr_jobs_cache_hits():
@@ -94,7 +94,7 @@ def incr_jobs_cache_hits():
redis_store.incr(JOBS_CACHE_HITS) redis_store.incr(JOBS_CACHE_HITS)
hits = redis_store.get(JOBS_CACHE_HITS).decode("utf-8") hits = redis_store.get(JOBS_CACHE_HITS).decode("utf-8")
misses = redis_store.get(JOBS_CACHE_MISSES).decode("utf-8") misses = redis_store.get(JOBS_CACHE_MISSES).decode("utf-8")
current_app.logger.info(f"JOBS CACHE HIT hits {hits} misses {misses}") current_app.logger.debug(f"JOBS CACHE HIT hits {hits} misses {misses}")
def extract_phones(job): def extract_phones(job):
@@ -120,9 +120,13 @@ def extract_phones(job):
phone_index = phone_index + 1 phone_index = phone_index + 1
current_app.logger.info(f"PHONE INDEX IS NOW {phone_index}") current_app.logger.info(f"PHONE INDEX IS NOW {phone_index}")
current_app.logger.info(f"LENGTH OF ROW IS {len(row)}") current_app.logger.info(f"LENGTH OF ROW IS {len(row)}")
my_phone = row[phone_index] if phone_index >= len(row):
my_phone = re.sub(r"[\+\s\(\)\-\.]*", "", my_phone) phones[job_row] = "Error: can't retrieve phone number"
phones[job_row] = my_phone current_app.logger.error("Corrupt csv file, missing columns job_id {job_id} service_id {service_id}")
else:
my_phone = row[phone_index]
my_phone = re.sub(r"[\+\s\(\)\-\.]*", "", my_phone)
phones[job_row] = my_phone
job_row = job_row + 1 job_row = job_row + 1
return phones return phones