darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-18 03:41:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

improve error handling around corrupt csv files

Browse Source
This commit is contained in:
Kenneth Kehl
2025-02-20 08:00:39 -08:00
parent f9f1acfaba
commit eb8d18bf6b
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/aws/s3.py
View File

@@ -396,7 +396,7 @@ def get_job_from_s3(service_id, job_id):
return None return None
def extract_phones(job): def extract_phones(job, service_id, job_id):
job_csv_data = StringIO(job) job_csv_data = StringIO(job)
csv_reader = csv.reader(job_csv_data) csv_reader = csv.reader(job_csv_data)
first_row = next(csv_reader) first_row = next(csv_reader)
@@ -415,9 +415,11 @@ def extract_phones(job):
phones[job_row] = "Unavailable" phones[job_row] = "Unavailable"
current_app.logger.error( current_app.logger.error(
f"Corrupt csv file, missing columns or\ f"Corrupt csv file, missing columns or\
possibly a byte order mark in the file, row looks like {row}", possibly a byte order mark in the file, \
row: {row} service_id {service_id} job_id {job_id}",
) )
# If the file is corrupt, stop trying to process it.
return phones
else: else:
my_phone = row[phone_index] my_phone = row[phone_index]
my_phone = re.sub(r"[\+\s\(\)\-\.]*", "", my_phone) my_phone = re.sub(r"[\+\s\(\)\-\.]*", "", my_phone)
@@ -460,7 +462,7 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
) )
return "Unavailable" return "Unavailable"
phones = extract_phones(job) phones = extract_phones(job, service_id, job_id)
set_job_cache(f"{job_id}_phones", phones) set_job_cache(f"{job_id}_phones", phones)
# If we can find the quick dictionary, use it # If we can find the quick dictionary, use it