darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 08:21:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

be stricter on broadcast message area validation

Browse Source 
even if there is a json struct, make sure it actually contains polygons,
or we'll send to the entire country.
This commit is contained in:
Leo Hemsted
2021-02-01 19:01:40 +00:00
parent bbae209200
commit e9f9fe8101
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/broadcast_message/rest.py
View File

@@ -56,7 +56,7 @@ def _update_broadcast_message(broadcast_message, new_status, updating_user):
f'User {updating_user.id} cannot approve their own broadcast_message {broadcast_message.id}', f'User {updating_user.id} cannot approve their own broadcast_message {broadcast_message.id}',
status_code=400 status_code=400
) )
elif not broadcast_message.areas: elif len(broadcast_message.areas['simple_polygons']) == 0:
raise InvalidRequest( raise InvalidRequest(
f'broadcast_message {broadcast_message.id} has no selected areas and so cannot be broadcasted.', f'broadcast_message {broadcast_message.id} has no selected areas and so cannot be broadcasted.',
status_code=400 status_code=400