From e97b567e9eee9b219a5c9f6fc59199ac9e49d254 Mon Sep 17 00:00:00 2001 From: Kenneth Kehl <@kkehl@flexion.us> Date: Mon, 22 Jul 2024 10:05:21 -0700 Subject: [PATCH] code review feedback --- app/aws/s3.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/aws/s3.py b/app/aws/s3.py index bfc6cd64c..0720c59ed 100644 --- a/app/aws/s3.py +++ b/app/aws/s3.py @@ -36,7 +36,7 @@ def list_s3_objects(): response = s3.list_objects_v2(Bucket=bucket_name) while True: for obj in response.get("Contents", []): - objects.append(obj["Key"]) + yield obj["Key"] if "NextContinuationToken" in response: response = s3.list_objects_v2( Bucket=bucket_name, @@ -48,7 +48,7 @@ def list_s3_objects(): current_app.logger.error( f"An error occurred while regenerating cache #notify-admin-1200 {e}" ) - return objects + def get_s3_files():