diff --git a/.github/ISSUE_TEMPLATE/create-new-adr-form.yml b/.github/ISSUE_TEMPLATE/create-new-adr-form.yml index 341aa66bc..4f170c3db 100644 --- a/.github/ISSUE_TEMPLATE/create-new-adr-form.yml +++ b/.github/ISSUE_TEMPLATE/create-new-adr-form.yml @@ -42,8 +42,8 @@ body: label: Implemented description: Is this ADR implemented? options: - - Yes - - No + - 'Yes' + - 'No' validations: required: true - type: input diff --git a/docs/adrs/0001-establishing-adrs-for-us-notify.md b/docs/adrs/0001-establishing-adrs-for-us-notify.md index efe6f818d..b15f2f3ab 100644 --- a/docs/adrs/0001-establishing-adrs-for-us-notify.md +++ b/docs/adrs/0001-establishing-adrs-for-us-notify.md @@ -3,7 +3,7 @@ | CREATED DATE | LAST UPDATED | STATUS | AUTHOR | STAKEHOLDERS | | :---: | :---: | :---: | :---: | :---: | -| 06/01/2023 | 06/05/2023 | Accepted | @ccostino | @stvnrlly | +| 06/01/2023 | 06/15/2023 | Accepted | @ccostino | @stvnrlly | ## CONTEXT AND PROBLEM STATEMENT @@ -103,11 +103,11 @@ These are the key considerations for creating ADRs for US Notify: - Requires being mindful of what can live in the public space vs. not -## PROPOSED OPTION: Architectural Decision Records +## CHOSEN OPTION: Architectural Decision Records -I am proposing that our team adopts using Architectural Decision Records going -forward for any decisions that need to be proposed or discussed that will have a -significant impact on the platform. +Our team has chosen to adopt Architectural Decision Records going forward for +any decisions that need to be proposed or discussed that will have a significant +impact on the platform. By documenting our changes in this fashion, it will improve our team's development practices and software quality in a few ways: diff --git a/docs/adrs/0002-how-to-handle-timezones.md b/docs/adrs/0002-how-to-handle-timezones.md index d46e4bf50..39612e957 100644 --- a/docs/adrs/0002-how-to-handle-timezones.md +++ b/docs/adrs/0002-how-to-handle-timezones.md @@ -3,7 +3,7 @@ | CREATED DATE | LAST UPDATED | STATUS | AUTHOR | STAKEHOLDERS | | :---: | :---: | :---: | :---: | :---: | -| 06/06/2023 | N/A | Accepted | @terrazoon, @ccostino | @GSA/notify-contributors | +| 06/06/2023 | 06/15/2023 | Accepted | @terrazoon, @ccostino | @GSA/notify-contributors | ## CONTEXT AND PROBLEM STATEMENT @@ -106,7 +106,7 @@ Cons of converting parts of the frontend now: customization, if any. -## PROPOSED OR CHOSEN OPTION: Proposed/Chosen Option Title Here +## CHOSEN OPTION: Backend UTC, frontend UTC After talking through each of these options together as a team, we have decided to move forward with converting the backend to UTC fully and pairing that work diff --git a/docs/adrs/0003-implementing-invite-expirations.md b/docs/adrs/0003-implementing-invite-expirations.md index 3a9fd0bb3..926a38616 100644 --- a/docs/adrs/0003-implementing-invite-expirations.md +++ b/docs/adrs/0003-implementing-invite-expirations.md @@ -3,7 +3,7 @@ | CREATED DATE | LAST UPDATED | STATUS | AUTHOR | STAKEHOLDERS | | :---: | :---: | :---: | :---: | :---: | -| 06/06/2023 | N/A | Proposed | @ccostino | @GSA/notify-contributors | +| 06/06/2023 | 06/15/2023 | Proposed | @ccostino | @GSA/notify-contributors | ## CONTEXT AND PROBLEM STATEMENT @@ -82,7 +82,7 @@ change: (especially any related to scheduled jobs). -## PROPOSED OR CHOSEN OPTION: Proposed/Chosen Option Title Here +## PROPOSED OPTION: Adjust `InvitedUser` management in the API I am proposing we adjust the `InvitedUser` management in the API and get these updates in place first for future UI changes, because without them we cannot diff --git a/docs/adrs/README.md b/docs/adrs/README.md index 0b1b9c895..3a15c526e 100644 --- a/docs/adrs/README.md +++ b/docs/adrs/README.md @@ -172,6 +172,6 @@ top!). | ADR | TITLE | CURRENT STATUS | IMPLEMENTED | LAST MODIFIED | | :---: | :---: | :---: | :---: | :---: | -| [ADR-0003](./0003-implementing-invite-expirations.md) | [Implementing User Invite Expirations](./0003-implementing-invite-expirations.md) | Proposed | No | 06/06/2023 | -| [ADR-0002](./0002-how-to-handle-timezones.md) | [Determine How to Handle Timezones in US Notify](./0002-how-to-handle-timezones.md) | Accepted | Yes | 06/06/2023 | -| [ADR-0001](./0001-establishing-adrs-for-us-notify.md) | [Establishing ADRs for US Notify](./0001-establishing-adrs-for-us-notify.md) | Accepted | Yes | 06/05/2023 | +| [ADR-0003](./0003-implementing-invite-expirations.md) | [Implementing User Invite Expirations](./0003-implementing-invite-expirations.md) | Proposed | No | 06/15/2023 | +| [ADR-0002](./0002-how-to-handle-timezones.md) | [Determine How to Handle Timezones in US Notify](./0002-how-to-handle-timezones.md) | Accepted | Yes | 06/15/2023 | +| [ADR-0001](./0001-establishing-adrs-for-us-notify.md) | [Establishing ADRs for US Notify](./0001-establishing-adrs-for-us-notify.md) | Accepted | Yes | 06/15/2023 |