darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 13:38:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update service schema to add letter_logo_filename

Browse Source 
Added the filename of a service's letter logo to the service schema. We want
this in the schema so that it is possible to call
`current_service.letter_logo_filename` from notifications-admin and to pass this value
through to template-preview.
This commit is contained in:
Katie Smith
2018-10-16 14:50:10 +01:00
parent e0056aad3f
commit e7f0a414ce
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/schemas.py
View File

@@ -205,12 +205,16 @@ class ServiceSchema(BaseSchema):
created_by = field_for(models.Service, 'created_by', required=True) created_by = field_for(models.Service, 'created_by', required=True)
organisation_type = field_for(models.Service, 'organisation_type') organisation_type = field_for(models.Service, 'organisation_type')
dvla_organisation = field_for(models.Service, 'dvla_organisation') dvla_organisation = field_for(models.Service, 'dvla_organisation')
letter_logo_filename = fields.Method(method_name='get_letter_logo_filename')
permissions = fields.Method("service_permissions") permissions = fields.Method("service_permissions")
email_branding = field_for(models.Service, 'email_branding') email_branding = field_for(models.Service, 'email_branding')
organisation = field_for(models.Service, 'organisation') organisation = field_for(models.Service, 'organisation')
override_flag = False override_flag = False
letter_contact_block = fields.Method(method_name="get_letter_contact") letter_contact_block = fields.Method(method_name="get_letter_contact")
def get_letter_logo_filename(self, service):
return service.dvla_organisation.filename
def service_permissions(self, service): def service_permissions(self, service):
return [p.permission for p in service.permissions] return [p.permission for p in service.permissions]

1
tests/app/service/test_rest.py
View File

@@ -139,6 +139,7 @@ def test_get_service_by_id(admin_request, sample_service):
assert json_resp['data']['dvla_organisation'] == '001' assert json_resp['data']['dvla_organisation'] == '001'
assert json_resp['data']['prefix_sms'] is True assert json_resp['data']['prefix_sms'] is True
assert json_resp['data']['postage'] == 'second' assert json_resp['data']['postage'] == 'second'
assert json_resp['data']['letter_logo_filename'] == 'hm-government'
@pytest.mark.parametrize('detailed', [True, False]) @pytest.mark.parametrize('detailed', [True, False])