From e6b7e0e16cbbb867fb089536e43922b55d310b1b Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 22 Jun 2020 10:20:53 +0100 Subject: [PATCH] Rename JSONModel to SerialisedModel 1/2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This class doesn’t actually wrap JSON, it wraps serialised data. So this name feels better. This commit only renames the file for an easier diff. --- app/notifications/validators.py | 2 +- app/{json_models.py => serialised_models.py} | 0 tests/app/notifications/test_process_notification.py | 2 +- tests/app/notifications/test_validators.py | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-) rename app/{json_models.py => serialised_models.py} (100%) diff --git a/app/notifications/validators.py b/app/notifications/validators.py index 9ce9ed6c9..8bc19d2d9 100644 --- a/app/notifications/validators.py +++ b/app/notifications/validators.py @@ -21,7 +21,7 @@ from app.notifications.process_notifications import create_content_for_notificat from app.utils import get_public_notify_type_text from app.dao.service_email_reply_to_dao import dao_get_reply_to_by_id from app.dao.service_letter_contact_dao import dao_get_letter_contact_by_id -from app.json_models import TemplateJSONModel +from app.serialised_models import TemplateJSONModel from gds_metrics.metrics import Histogram diff --git a/app/json_models.py b/app/serialised_models.py similarity index 100% rename from app/json_models.py rename to app/serialised_models.py diff --git a/tests/app/notifications/test_process_notification.py b/tests/app/notifications/test_process_notification.py index 6968e6220..49c114c74 100644 --- a/tests/app/notifications/test_process_notification.py +++ b/tests/app/notifications/test_process_notification.py @@ -20,7 +20,7 @@ from app.notifications.process_notifications import ( send_notification_to_queue, simulated_recipient ) -from app.json_models import TemplateJSONModel +from app.serialised_models import TemplateJSONModel from notifications_utils.recipients import validate_and_format_phone_number, validate_and_format_email_address from app.v2.errors import BadRequestError from tests.app.db import create_service, create_template, create_api_key diff --git a/tests/app/notifications/test_validators.py b/tests/app/notifications/test_validators.py index c29470c5e..e2e200f87 100644 --- a/tests/app/notifications/test_validators.py +++ b/tests/app/notifications/test_validators.py @@ -23,7 +23,7 @@ from app.notifications.validators import ( validate_and_format_recipient, validate_template, ) -from app.json_models import TemplateJSONModel +from app.serialised_models import TemplateJSONModel from app.utils import get_template_instance from app.v2.errors import (