darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

add new template stat read pseudocode

Browse Source 
we can't use this new code until the new redis keys have been popualted
for the last seven days
This commit is contained in:
Leo Hemsted
2018-03-22 16:18:22 +00:00
parent a0f74b35e1
commit e692e06b7f
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
app/template_statistics/rest.py
View File

@@ -79,7 +79,22 @@ def get_template_statistics_for_7_days(limit_days, service_id):
if cache_values: if cache_values:
redis_store.set_hash_and_expire(cache_key, redis_store.set_hash_and_expire(cache_key,
cache_values, cache_values,
current_app.config.get('EXPIRE_CACHE_IN_SECONDS', 600)) current_app.config['EXPIRE_CACHE_IN_SECONDS'])
else: else:
stats = dao_get_templates_for_cache(template_stats_by_id.items()) stats = dao_get_templates_for_cache(template_stats_by_id.items())
return stats return stats
# TODO: can only switch to this code when redis has been populated (either through time passing or a manual step)
# from collections import Counter
# from notifications_utils.redis_client import RedisException
# template_stats_by_id = Counter()
# for day in last_7_days:
# # "<SERVICE_ID>-template-usage-{YYYY-MM-DD}"
# key = cache_key_for_service_templates_used_per_day(service_id, limit_days)
# try:
# template_stats_by_id += Counter(redis_store.get_all_from_hash(key, raise_exception=True))
# except RedisException:
# # TODO: ????
#
# # TODO: streamline db query and avoid weird unions if possible.
# return dao_get_templates_for_cache(template_stats_by_id.items())