darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 13:38:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

Corrected error message format

Browse Source
This commit is contained in:
Adam Shimali
2016-04-04 14:51:56 +01:00
parent 0d06be05e1
commit e4a5e3890a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/template_statistics/rest.py
View File

@@ -24,9 +24,9 @@ def get_template_statistics_for_service(service_id):
try: try:
limit_days = int(request.args['limit_days']) limit_days = int(request.args['limit_days'])
except ValueError as e: except ValueError as e:
error = 'Limit days {} is not an integer'.format(request.args['limit_days']) error = '{} is not an integer'.format(request.args['limit_days'])
current_app.logger.error(error) current_app.logger.error(error)
return jsonify(result="error", message=[error]), 400 return jsonify(result="error", message={'limit_days': [error]}), 400
else: else:
limit_days = None limit_days = None
stats = dao_get_template_statistics_for_service(service_id, limit_days=limit_days) stats = dao_get_template_statistics_for_service(service_id, limit_days=limit_days)

2
tests/app/template_statistics/test_rest.py
View File

@@ -133,4 +133,4 @@ def test_get_all_template_statistics_with_bad_limit_arg_returns_400(notify_api,
assert response.status_code == 400 assert response.status_code == 400
json_resp = json.loads(response.get_data(as_text=True)) json_resp = json.loads(response.get_data(as_text=True))
assert json_resp['result'] == 'error' assert json_resp['result'] == 'error'
assert json_resp['message'] == ['Limit days blurk is not an integer'] assert json_resp['message'] == {'limit_days': ['blurk is not an integer']}