darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Kenneth Kehl
2024-01-12 15:08:59 -08:00
parent 3414c8e15a
commit e45d4dbac9
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/celery/scheduled_tasks.py
View File

@@ -112,9 +112,11 @@ def check_db_notification_fails():
on a breach. I.e., if the last number was at 23% and the current number is 27%, send an email. on a breach. I.e., if the last number was at 23% and the current number is 27%, send an email.
But if the last number was 26% and the current is 27%, don't. But if the last number was 26% and the current is 27%, don't.
""" """
last_value = redis_store.get("LAST_DB_NOTIFICATION_COUNT").decode("utf-8") last_value = redis_store.get("LAST_DB_NOTIFICATION_COUNT")
if not last_value: if not last_value:
last_value = 0 last_value = 0
else:
last_value = int(last_value.decode("utf-8"))
failed_count = dao_get_failed_notification_count() failed_count = dao_get_failed_notification_count()
if failed_count > last_value: if failed_count > last_value:

8
tests/app/celery/test_scheduled_tasks.py
View File

@@ -72,6 +72,8 @@ def test_should_check_db_notification_fails_task_less_than_25_percent(
mock_dao = mocker.patch( mock_dao = mocker.patch(
"app.celery.scheduled_tasks.dao_get_failed_notification_count" "app.celery.scheduled_tasks.dao_get_failed_notification_count"
) )
mock_redis = mocker.patch("app.celery.scheduled_tasks.redis_store")
mock_redis.get.return_value = 0
mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use") mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use")
mock_dao.return_value = 10 mock_dao.return_value = 10
check_db_notification_fails() check_db_notification_fails()
@@ -88,13 +90,13 @@ def test_should_check_db_notification_fails_task_over_50_percent(
"app.celery.scheduled_tasks.dao_get_failed_notification_count" "app.celery.scheduled_tasks.dao_get_failed_notification_count"
) )
mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use") mock_provider = mocker.patch("app.celery.scheduled_tasks.provider_to_use")
mock_redis = mocker.patch("app.celery.scheduled_tasks.redis_store.get") mock_redis = mocker.patch("app.celery.scheduled_tasks.redis_store")
mock_dao.return_value = 5001 mock_dao.return_value = 5001
mock_redis.return_value = 0 mock_redis.get.return_value = "0".encode("utf-8")
check_db_notification_fails() check_db_notification_fails()
assert mock_provider.call_count == 1 assert mock_provider.call_count == 1
mock_redis.return_value = 5001 mock_redis.get.return_value = "5001".encode("utf-8")
check_db_notification_fails() check_db_notification_fails()
assert mock_provider.call_count == 1 assert mock_provider.call_count == 1