darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-17 21:18:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1918 from alphagov/wrap-get_json-in-try-except

Browse Source 
Wrap exception to return a sensible message to the client
This commit is contained in:
Rebecca Law
2018-07-03 11:03:01 +01:00
committed by GitHub
parent d2f8a206a8 6da552a00b
commit e3b3a407c9
2 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/app/v2/notifications/test_post_notifications.py
View File

@@ -839,3 +839,12 @@ def test_post_notification_without_document_upload_permission(client, notify_db,
headers=[('Content-Type', 'application/json'), auth_header])
assert response.status_code == 400, response.get_data(as_text=True)
def test_post_notification_returns_400_when_get_json_throws_exception(client, sample_email_template, rmock, mocker):
auth_header = create_authorization_header(service_id=sample_email_template.service_id)
response = client.post(
path="v2/notifications/email",
data="[",
headers=[('Content-Type', 'application/json'), auth_header])
assert response.status_code == 400