darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use sanitised pdfs for sending and handle invalid pdfs, details below:

Browse Source 
- pass new, sanitised pdf for sending
- move invalid pdfs to a newly created bucket
- set status fro notifications that failed pdf validation to a new status validation-failed
- adjust existing tests
This commit is contained in:
Pea Tyczynska
2018-09-03 13:24:51 +01:00
committed by Leo Hemsted
parent cd563283d5
commit e22e7245fe
8 changed files with 61 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/celery/test_letters_pdf_tasks.py
View File

@@ -354,16 +354,16 @@ def test_process_letter_task_check_virus_scan_passed(
sample_letter_notification.status = 'pending-virus-check'
sample_letter_notification.key_type = key_type
mock_s3upload = mocker.patch('app.celery.letters_pdf_tasks.s3upload')
mock_sanitise = mocker.patch('app.celery.letters_pdf_tasks._sanitise_precomiled_pdf')
mock_sanitise = mocker.patch('app.celery.letters_pdf_tasks._sanitise_precomiled_pdf', return_value="success")
process_virus_scan_passed(filename)
assert sample_letter_notification.status == noti_status
mock_s3upload.assert_called_once_with(
filedata=b'pdf_content',
region='eu-west-1',
bucket_name=target_bucket_name,
file_location=destination_folder + filename
filedata="success",
file_location=destination_folder + filename,
region='eu-west-1',
)
mock_sanitise.assert_called_once_with(
ANY,