darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 02:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to switch properly when providers have equal priority with test

Browse Source
This commit is contained in:
Imdad Ahad
2017-01-23 13:36:04 +00:00
parent 0a277b26b6
commit e1d1769345
4 changed files with 29 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/dao/test_provider_details_dao.py
View File

@@ -133,8 +133,6 @@ def test_switch_sms_provider_to_current_provider_does_not_switch(
def test_switch_sms_provider_to_inactive_provider_does_not_switch(
notify_db,
notify_db_session,
restore_provider_details,
current_sms_provider,
mocker
@@ -151,13 +149,26 @@ def test_switch_sms_provider_to_inactive_provider_does_not_switch(
def test_toggle_sms_provider_switches_provider(
notify_db,
notify_db_session,
restore_provider_details,
current_sms_provider,
mocker
):
dao_toggle_sms_provider()
dao_toggle_sms_provider(current_sms_provider.identifier)
new_provider = get_current_provider('sms')
assert new_provider.identifier != current_sms_provider.identifier
assert new_provider.priority < current_sms_provider.priority
def test_toggle_sms_provider_switches_when_provider_priorities_are_equal(
restore_provider_details,
current_sms_provider,
mocker
):
new_provider = get_alternative_sms_provider(current_sms_provider.identifier)
current_sms_provider.priority = new_provider.priority
dao_update_provider_details(current_sms_provider)
dao_toggle_sms_provider(current_sms_provider.identifier)
assert new_provider.identifier != current_sms_provider.identifier
assert new_provider.priority < current_sms_provider.priority