darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Allow services to add puntuation to or change the case of their name

Browse Source 
Changed the '/service/unique' endpoint to optionally accept the
service_id parameter. It now doesn't matter if a user tries to change
the capitalization or add punctuation to their own service name. But
there should still be an error if a user tries to change the punctuation
or capitalization of another service.

service_id needs to be allowed to be None until notifications-admin is
updated to always pass in the service_id.
This commit is contained in:
Katie Smith
2018-02-13 15:25:24 +00:00
parent 16c78a8924
commit e1cc8175d7
2 changed files with 64 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
tests/app/service/test_rest.py
View File

@@ -2202,6 +2202,58 @@ def test_is_service_name_unique_returns_200_if_unique(client):
assert json.loads(response.get_data(as_text=True)) == {"result": True}
def test_is_service_name_unique_returns_200_if_unique_and_service_id_given(
client,
notify_db,
notify_db_session
):
service = create_service(service_name='unique', email_from='unique')
service_id = str(service.id)
response = client.get(
'/service/unique?service_id={}&name=something&email_from=something'.format(service_id),
headers=[create_authorization_header()]
)
assert response.status_code == 200
assert json.loads(response.get_data(as_text=True)) == {"result": True}
def test_is_service_name_unique_returns_200_when_capitalized(
client,
notify_db,
notify_db_session
):
service = create_service(service_name='unique', email_from='unique')
service_id = str(service.id)
response = client.get(
'/service/unique?service_id={}&name={}&email_from={}'.format(service_id, 'UNIQUE', 'unique'),
headers=[create_authorization_header()]
)
assert response.status_code == 200
assert json.loads(response.get_data(as_text=True)) == {"result": True}
def test_is_service_name_unique_returns_false_if_checking_capitalization_of_different_service(
client,
notify_db,
notify_db_session
):
create_service(service_name='unique', email_from='unique')
different_service_id = '111aa111-2222-bbbb-aaaa-111111111111'
response = client.get(
'/service/unique?service_id={}&name={}&email_from={}'.format(
different_service_id, 'UNIQUE', 'unique'),
headers=[create_authorization_header()]
)
assert response.status_code == 200
assert json.loads(response.get_data(as_text=True)) == {"result": False}
@pytest.mark.parametrize('name, email_from',
[("something unique", "something"),
("unique", "something.unique"),