More Enum goodness.

Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
This commit is contained in:
Cliff Hill
2024-01-18 10:26:40 -05:00
parent 43f18eed6a
commit df866e40f7
26 changed files with 379 additions and 278 deletions

View File

@@ -4,7 +4,7 @@ from app.dao.service_permissions_dao import (
dao_fetch_service_permissions,
dao_remove_service_permission,
)
from app.models import EMAIL_TYPE, INBOUND_SMS_TYPE, INTERNATIONAL_SMS_TYPE, SMS_TYPE
from app.models import ServicePermissionType
from tests.app.db import create_service, create_service_permission
@@ -15,22 +15,23 @@ def service_without_permissions(notify_db_session):
def test_create_service_permission(service_without_permissions):
service_permissions = create_service_permission(
service_id=service_without_permissions.id, permission=SMS_TYPE
service_id=service_without_permissions.id, permission=ServicePermissionType.SMS
)
assert len(service_permissions) == 1
assert service_permissions[0].service_id == service_without_permissions.id
assert service_permissions[0].permission == SMS_TYPE
assert service_permissions[0].permission == ServicePermissionType.SMS
def test_fetch_service_permissions_gets_service_permissions(
service_without_permissions,
):
create_service_permission(
service_id=service_without_permissions.id, permission=INTERNATIONAL_SMS_TYPE
service_id=service_without_permissions.id,
permission=ServicePermissionType.INTERNATIONAL_SMS,
)
create_service_permission(
service_id=service_without_permissions.id, permission=SMS_TYPE
service_id=service_without_permissions.id, permission=ServicePermissionType.SMS
)
service_permissions = dao_fetch_service_permissions(service_without_permissions.id)
@@ -40,22 +41,30 @@ def test_fetch_service_permissions_gets_service_permissions(
sp.service_id == service_without_permissions.id for sp in service_permissions
)
assert all(
sp.permission in [INTERNATIONAL_SMS_TYPE, SMS_TYPE]
sp.permission in {
ServicePermissionType.INTERNATIONAL_SMS,
ServicePermissionType.SMS,
}
for sp in service_permissions
)
def test_remove_service_permission(service_without_permissions):
create_service_permission(
service_id=service_without_permissions.id, permission=EMAIL_TYPE
service_id=service_without_permissions.id,
permission=ServicePermissionType.EMAIL,
)
create_service_permission(
service_id=service_without_permissions.id, permission=INBOUND_SMS_TYPE
service_id=service_without_permissions.id,
permission=ServicePermissionType.INBOUND_SMS,
)
dao_remove_service_permission(service_without_permissions.id, EMAIL_TYPE)
dao_remove_service_permission(
service_without_permissions.id,
ServicePermissionType.EMAIL,
)
permissions = dao_fetch_service_permissions(service_without_permissions.id)
assert len(permissions) == 1
assert permissions[0].permission == INBOUND_SMS_TYPE
assert permissions[0].permission == ServicePermissionType.INBOUND_SMS
assert permissions[0].service_id == service_without_permissions.id