darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make email_from and subject required attributes of the email_content schema.

Browse Source 
Update the format_checkers to raise the specific exception that why the validator can handle multiple messages.
Which led to a refactor of build_error_message.
This commit is contained in:
Rebecca Law
2016-11-16 17:25:00 +00:00
parent 68537d960a
commit df62be421f
3 changed files with 36 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/v2/notifications/test_notification_schemas.py
View File

@@ -57,14 +57,25 @@ def test_post_sms_schema_with_personalisation_that_is_not_a_dict():
@pytest.mark.parametrize('invalid_phone_number',
['notaphoneumber', '08515111111', '07515111*11'])
['08515111111', '07515111*11', 'notaphoneumber'])
def test_post_sms_request_invalid_phone_number(invalid_phone_number):
j = {"phone_number": invalid_phone_number,
"template_id": str(uuid.uuid4())
}
with pytest.raises(InvalidPhoneError):
with pytest.raises(ValidationError):
validate(j, post_sms_request)
def test_post_sms_request_invalid_phone_number_and_missing_template():
j = {"phone_number": '08515111111',
}
with pytest.raises(ValidationError) as e:
validate(j, post_sms_request)
error = json.loads(e.value.message)
print(error)
assert len(error.get('errors')) == 2
valid_response = {
"id": str(uuid.uuid4()),
"content": {"body": "contents of message",
@@ -106,7 +117,7 @@ def test_post_sms_response_schema_missing_uri():
valid_post_email_json = {"email_address": "test@example.gov.uk",
"template_id": str(uuid.uuid4())
}
valid_post_emaiL_json_with_optionals = {
valid_post_email_json_with_optionals = {
"email_address": "test@example.gov.uk",
"template_id": str(uuid.uuid4()),
"reference": "reference from caller",
@@ -114,7 +125,7 @@ valid_post_emaiL_json_with_optionals = {
}
@pytest.mark.parametrize("input", [valid_post_email_json, valid_post_emaiL_json_with_optionals])
@pytest.mark.parametrize("input", [valid_post_email_json, valid_post_email_json_with_optionals])
def test_post_email_schema_is_valid(input):
assert validate(input, post_email_request) == input
@@ -128,7 +139,7 @@ def test_post_email_schema_bad_uuid_and_missing_email_address():
def test_post_email_schema_invalid_email_address():
j = {"template_id": str(uuid.uuid4()),
"email_address": "notavalidemail@address"}
with pytest.raises(InvalidEmailError):
with pytest.raises(ValidationError):
validate(j, post_email_request)