mirror of
https://github.com/GSA/notifications-api.git
synced 2026-08-24 16:23:44 -04:00
@@ -100,7 +100,7 @@ def test_should_reject_bad_phone_numbers(notify_api, sample_template, mocker):
|
||||
[
|
||||
(TemplateType.SMS, "+447700900855"),
|
||||
(TemplateType.EMAIL, "ok@ok.com"),
|
||||
]
|
||||
],
|
||||
)
|
||||
def test_send_notification_invalid_template_id(
|
||||
notify_api, sample_template, mocker, fake_uuid, template_type, to
|
||||
@@ -339,7 +339,9 @@ def test_should_send_notification_if_restricted_and_a_service_user(
|
||||
)
|
||||
|
||||
template = (
|
||||
sample_template if template_type == TemplateType.SMS else sample_email_template
|
||||
sample_template
|
||||
if template_type == TemplateType.SMS
|
||||
else sample_email_template
|
||||
)
|
||||
to = (
|
||||
template.service.created_by.mobile_number
|
||||
@@ -769,7 +771,9 @@ def test_should_persist_notification(
|
||||
"app.notifications.process_notifications.uuid.uuid4", return_value=fake_uuid
|
||||
)
|
||||
|
||||
template = sample_template if template_type == TemplateType.SMS else sample_email_template
|
||||
template = (
|
||||
sample_template if template_type == TemplateType.SMS else sample_email_template
|
||||
)
|
||||
to = (
|
||||
sample_template.service.created_by.mobile_number
|
||||
if template_type == TemplateType.SMS
|
||||
@@ -826,7 +830,9 @@ def test_should_delete_notification_and_return_error_if_redis_fails(
|
||||
"app.notifications.process_notifications.uuid.uuid4", return_value=fake_uuid
|
||||
)
|
||||
|
||||
template = sample_template if template_type == TemplateType.SMS else sample_email_template
|
||||
template = (
|
||||
sample_template if template_type == TemplateType.SMS else sample_email_template
|
||||
)
|
||||
to = (
|
||||
sample_template.service.created_by.mobile_number
|
||||
if template_type == TemplateType.SMS
|
||||
@@ -1086,7 +1092,7 @@ def test_create_template_doesnt_raise_with_too_much_personalisation(
|
||||
[
|
||||
(TemplateType.SMS, True),
|
||||
(TemplateType.EMAIL, False),
|
||||
]
|
||||
],
|
||||
)
|
||||
def test_create_template_raises_invalid_request_when_content_too_large(
|
||||
sample_service, template_type, should_error
|
||||
|
||||
@@ -203,7 +203,9 @@ def test_send_one_off_notification_raises_if_cant_send_to_recipient(
|
||||
template = create_template(service=service)
|
||||
dao_add_and_commit_guest_list_contacts(
|
||||
[
|
||||
ServiceGuestList.from_string(service.id, GuestListRecipientType.MOBILE, "2028765309"),
|
||||
ServiceGuestList.from_string(
|
||||
service.id, GuestListRecipientType.MOBILE, "2028765309"
|
||||
),
|
||||
]
|
||||
)
|
||||
|
||||
|
||||
@@ -1723,7 +1723,9 @@ def test_get_all_notifications_for_service_filters_notifications_when_using_post
|
||||
service_2 = create_service(service_name="2")
|
||||
|
||||
service_1_sms_template = create_template(service_1)
|
||||
service_1_email_template = create_template(service_1, template_type=TemplateType.EMAIL)
|
||||
service_1_email_template = create_template(
|
||||
service_1, template_type=TemplateType.EMAIL
|
||||
)
|
||||
service_2_sms_template = create_template(service_2)
|
||||
|
||||
returned_notification = create_notification(
|
||||
|
||||
@@ -7,7 +7,9 @@ from app.service.sender import send_notification_to_service_users
|
||||
from tests.app.db import create_service, create_template, create_user
|
||||
|
||||
|
||||
@pytest.mark.parametrize("notification_type", [NotificationType.EMAIL, NotificationType.SMS])
|
||||
@pytest.mark.parametrize(
|
||||
"notification_type", [NotificationType.EMAIL, NotificationType.SMS]
|
||||
)
|
||||
def test_send_notification_to_service_users_persists_notifications_correctly(
|
||||
notify_service, notification_type, sample_service, mocker
|
||||
):
|
||||
|
||||
@@ -28,7 +28,9 @@ def test_get_guest_list_separates_emails_and_phones(client, sample_service):
|
||||
GuestListRecipientType.EMAIL,
|
||||
"service@example.com",
|
||||
),
|
||||
ServiceGuestList.from_string(sample_service.id, GuestListRecipientType.MOBILE, "2028675309"),
|
||||
ServiceGuestList.from_string(
|
||||
sample_service.id, GuestListRecipientType.MOBILE, "2028675309"
|
||||
),
|
||||
ServiceGuestList.from_string(
|
||||
sample_service.id,
|
||||
GuestListRecipientType.MOBILE,
|
||||
|
||||
Reference in New Issue
Block a user