diff --git a/app/celery/broadcast_message_tasks.py b/app/celery/broadcast_message_tasks.py index ce80ea54f..b512e0739 100644 --- a/app/celery/broadcast_message_tasks.py +++ b/app/celery/broadcast_message_tasks.py @@ -32,10 +32,10 @@ def send_broadcast_event(broadcast_event_id): def send_broadcast_provider_message(broadcast_event_id, provider): broadcast_event = dao_get_broadcast_event_by_id(broadcast_event_id) - broadcast_provider_message, message_number = create_broadcast_provider_message(broadcast_event, provider) + broadcast_provider_message = create_broadcast_provider_message(broadcast_event, provider) formatted_message_number = None if provider == BroadcastProvider.VODAFONE: - formatted_message_number = format_sequential_number(message_number.broadcast_provider_message_number) + formatted_message_number = format_sequential_number(broadcast_provider_message.message_number) current_app.logger.info( f'invoking cbc proxy to send ' diff --git a/app/dao/broadcast_message_dao.py b/app/dao/broadcast_message_dao.py index 5332b420d..f7016fdcb 100644 --- a/app/dao/broadcast_message_dao.py +++ b/app/dao/broadcast_message_dao.py @@ -60,4 +60,4 @@ def create_broadcast_provider_message(broadcast_event, provider): broadcast_provider_message_id=broadcast_provider_message_id) db.session.add(provider_message_number) db.session.commit() - return provider_message, provider_message_number + return provider_message diff --git a/app/models.py b/app/models.py index 494842b6b..c14408784 100644 --- a/app/models.py +++ b/app/models.py @@ -2483,6 +2483,8 @@ class BroadcastProviderMessage(db.Model): UniqueConstraint(broadcast_event_id, provider) + message_number = association_proxy('broadcast_provider_message_number', 'broadcast_provider_message_number') + class BroadcastProviderMessageNumber(db.Model): """ @@ -2500,6 +2502,9 @@ class BroadcastProviderMessageNumber(db.Model): broadcast_provider_message_id = db.Column( UUID(as_uuid=True), db.ForeignKey('broadcast_provider_message.id'), nullable=False ) + broadcast_provider_message = db.relationship( + 'BroadcastProviderMessage', backref=db.backref("broadcast_provider_message_number", uselist=False) + ) class ServiceBroadcastProviderRestriction(db.Model): diff --git a/tests/app/dao/test_broadcast_message_dao.py b/tests/app/dao/test_broadcast_message_dao.py index dd5a69ac4..a8fb160b5 100644 --- a/tests/app/dao/test_broadcast_message_dao.py +++ b/tests/app/dao/test_broadcast_message_dao.py @@ -53,7 +53,7 @@ def test_create_broadcast_provider_message_creates_in_correct_state(sample_broad transmitted_content={'body': 'Initial content'} ) - broadcast_provider_message, message_number = create_broadcast_provider_message(broadcast_event, 'fake-provider') + broadcast_provider_message = create_broadcast_provider_message(broadcast_event, 'fake-provider') assert broadcast_provider_message.status == 'sending' assert broadcast_provider_message.broadcast_event_id == broadcast_event.id