darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-07-08 10:27:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

improve logging

Browse Source
This commit is contained in:
Kenneth Kehl
2025-09-04 12:30:52 -07:00
parent c6e1e662ad
commit ded60409a8
11 changed files with 42 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
notifications_utils/clients/redis/redis_client.py
View File

@@ -80,7 +80,9 @@ class RedisClient:
try:
return self.scripts["delete-keys-by-pattern"](args=[pattern])
except Exception as e:
current_app.logger.exception(f"Exception in delete_by_pattern pattern={pattern}")
current_app.logger.exception(
f"Exception in delete_by_pattern pattern={pattern}"
)
self.__handle_exception(
e, raise_exception, "delete-by-pattern", pattern
)
@@ -130,7 +132,9 @@ class RedisClient:
result = pipe.execute()
return result[2] > limit
except Exception as e:
current_app.logger.exception(f"Exception in exceeded_rate_limit cache_key {cache_key} limit = {limit}")
current_app.logger.exception(
f"Exception in exceeded_rate_limit cache_key {cache_key} limit = {limit}"
)
self.__handle_exception(
e, raise_exception, "rate-limit-pipeline", cache_key
)

22
notifications_utils/recipients.py
View File

@@ -83,8 +83,10 @@ class RecipientCSV:
def guestlist(self, value):
try:
self._guestlist = list(value)
except TypeError as te:
current_app.logger.exception(f"Type error setting the guest list to {value}")
except TypeError:
current_app.logger.exception(
f"Type error setting the guest list to {value}"
)
self._guestlist = []
@property
@@ -112,7 +114,9 @@ class RecipientCSV:
try:
self._placeholders = list(value) + self.recipient_column_headers
except TypeError:
current_app.logger.exception(f"TypeError setting the placeholders to {value}")
current_app.logger.exception(
f"TypeError setting the placeholders to {value}"
)
self._placeholders = self.recipient_column_headers
self.placeholders_as_column_keys = [
InsensitiveDict.make_key(placeholder) for placeholder in self._placeholders
@@ -514,7 +518,9 @@ def is_us_phone_number(number):
try:
return _get_country_code(number) == us_prefix
except NumberParseException:
current_app.logger.exception("NumberParseException checking if phone number is US number")
current_app.logger.exception(
"NumberParseException checking if phone number is US number"
)
return False
@@ -660,7 +666,9 @@ def try_validate_and_format_phone_number(number, international=None, log_msg=Non
try:
return validate_and_format_phone_number(number, international)
except InvalidPhoneError as exc:
current_app.logger.exception("InvalidPhoneNumber while trying to validate and format phone number")
current_app.logger.exception(
"InvalidPhoneNumber while trying to validate and format phone number"
)
if log_msg:
current_app.logger.warning("{}: {}".format(log_msg, exc))
return number
@@ -738,7 +746,9 @@ def format_phone_number_human_readable(phone_number):
phone_number = validate_phone_number(phone_number, international=True)
except InvalidPhoneError:
# if there was a validation error, we want to shortcut out here, but still display the number on the front end
current_app.logger.exception("InvalidPhoneError trying to format_phone_number_human_readable()")
current_app.logger.exception(
"InvalidPhoneError trying to format_phone_number_human_readable()"
)
return phone_number
international_phone_info = get_international_phone_info(phone_number)