darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-04 12:18:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

remove notification_type and service from create_ft_billing

Browse Source 
they can both be inferred from the template, and specifying them just
leads to unnecessary risk of errors
This commit is contained in:
Leo Hemsted
2019-12-03 17:02:58 +00:00
parent ed5a52fe0d
commit dd57468147
7 changed files with 62 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/service/test_rest.py
View File

@@ -169,11 +169,11 @@ def test_get_live_services_data(sample_user, admin_request):
service = create_service(go_live_user=sample_user, go_live_at=datetime(2018, 1, 1))
service_2 = create_service(service_name='second', go_live_at=datetime(2019, 1, 1), go_live_user=sample_user)
template = create_template(service=service)
template2 = create_template(service=service, template_type='email')
sms_template = create_template(service=service)
email_template = create_template(service=service, template_type='email')
dao_add_service_to_organisation(service=service, organisation_id=org.id)
create_ft_billing(bst_date='2019-04-20', notification_type='sms', template=template, service=service)
create_ft_billing(bst_date='2019-04-20', notification_type='email', template=template2, service=service)
create_ft_billing(bst_date='2019-04-20', template=sms_template)
create_ft_billing(bst_date='2019-04-20', template=email_template)
create_annual_billing(service.id, 1, 2019)
create_annual_billing(service_2.id, 2, 2018)