darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 18:31:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

remove notification_type and service from create_ft_billing

Browse Source 
they can both be inferred from the template, and specifying them just
leads to unnecessary risk of errors
This commit is contained in:
Leo Hemsted
2019-12-03 17:02:58 +00:00
parent ed5a52fe0d
commit dd57468147
7 changed files with 62 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/provider_details/test_rest.py
View File

@@ -32,8 +32,8 @@ def test_get_provider_details_by_id(client, notify_db):
@freeze_time('2018-06-28 12:00')
def test_get_provider_contains_correct_fields(client, sample_service, sample_template):
create_ft_billing('2018-06-01', 'sms', sample_template, sample_service, provider='mmg', billable_unit=1)
def test_get_provider_contains_correct_fields(client, sample_template):
create_ft_billing('2018-06-01', sample_template, provider='mmg', billable_unit=1)
response = client.get(
'/provider-details',