Remove v2 error handler for InvalidPhoneError, no longer expect to throw this exception.

This commit is contained in:
Rebecca Law
2016-11-17 09:09:24 +00:00
parent df62be421f
commit dc5e21a78e
2 changed files with 0 additions and 22 deletions

View File

@@ -1,7 +1,6 @@
import json
import pytest
from flask import url_for
from notifications_utils.recipients import InvalidPhoneError
from sqlalchemy.exc import DataError
@@ -40,10 +39,6 @@ def app_for_test(mocker):
def raising_data_error():
raise DataError("There was a db problem", "params", "orig")
@blue.route("raise_phone_error", methods=["GET"])
def raising_invalid_phone_error():
raise InvalidPhoneError("The phone number is wrong")
@blue.route("raise_exception", methods=["GET"])
def raising_exception():
raise AssertionError("Raising any old exception")
@@ -121,13 +116,3 @@ def test_internal_server_error_handler(app_for_test):
error = json.loads(response.get_data(as_text=True))
assert error == {"status_code": 500,
"errors": [{"error": "AssertionError", "message": "Internal server error"}]}
def test_invalid_phone_error_handler(app_for_test):
with app_for_test.test_request_context():
with app_for_test.test_client() as client:
response = client.get(url_for("v2_under_test.raising_invalid_phone_error"))
assert response.status_code == 400
error = json.loads(response.get_data(as_text=True))
assert error == {"status_code": 400,
"errors": [{"error": "InvalidPhoneError", "message": "The phone number is wrong"}]}