darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding a scheduled task to processing missing rows from job

Browse Source 
Sometimes a job finishes but has missed a row in the middle. It is a mystery why this is happening, it could be that the task to save the notifications has been dropped.
So until we solve the missing let's find missing rows and process them.

A new scheduled task has been added to find any "finished" jobs that do not have enough notifications created. If there are missing notifications the job processes those rows for the job.
Adding the new task to beat schedule will be done in the next commit.

A unique key constraint has been added to Notifications to ensure that the row is not added twice. Any index or constraint can affect performance, but this unique constraint should not affect it enough for us to notice.
This commit is contained in:
Rebecca Law
2019-11-05 16:47:00 +00:00
parent 975af113e4
commit db5a50c5a7
7 changed files with 160 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/dao/jobs_dao.py
View File

@@ -191,17 +191,17 @@ def can_letter_job_be_cancelled(job):
def find_jobs_with_missing_rows():
# Jobs can be a maximum of 50,000 rows. It typically takes 5 minutes to create all those notifications.
# Using 10 minutes as a condition seems reasonable.
ten_minutes_ago = datetime.utcnow() - timedelta(minutes=10)
jobs_with_rows_missing = db.session.query(
func.count(Notification.id).label('count_notifications'),
Job.notification_count,
Job.id.label('job_id'),
Job.service_id
Job
).filter(
Job.job_status == JOB_STATUS_FINISHED
Job.job_status == JOB_STATUS_FINISHED,
Job.processing_finished < ten_minutes_ago
).group_by(
Job.notification_count,
Job.id.label('job_id'),
Job.service_id
Job
).having(
func.count(Notification.id) != Job.notification_count
)
@@ -211,7 +211,7 @@ def find_jobs_with_missing_rows():
def find_missing_row_for_job(job_id, job_size):
expected_row_numbers = db.session.query(
func.generate_series(0, job_size-1).label('row')
func.generate_series(0, job_size - 1).label('row')
).subquery()
query = db.session.query(
@@ -220,6 +220,6 @@ def find_missing_row_for_job(job_id, job_size):
).outerjoin(
Notification, and_(expected_row_numbers.c.row == Notification.job_row_number, Notification.job_id == job_id)
).filter(
Notification.job_row_number == None #noqa
Notification.job_row_number == None # noqa
)
return query.all()