darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 06:21:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactored notifications_dao

Browse Source 
- Introduce a `_raise` flag for `get_notification_by_id` so that sql alchemy will raise the NoResults error rather than the app
- Refactor `dao_set_created_live_letter_api_notifications_to_pending` to use a join for getting services that don't have `letters_as_pdf` as marginally faster.
This commit is contained in:
Ken Tsang
2017-12-12 11:56:42 +00:00
parent ab72d6f555
commit da93ba296e
3 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/dao/notification_dao/test_letter_api_notification_dao.py
View File

@@ -25,9 +25,7 @@ def test_should_only_get_letter_notifications(
assert ret == [sample_letter_notification]
def test_should_ignore_letters_as_pdf(
sample_letter_notification,
):
def test_should_ignore_letters_as_pdf(sample_letter_notification):
service = create_service(service_permissions=[LETTER_TYPE, 'letters_as_pdf'])
template = create_template(service, template_type=LETTER_TYPE)
create_notification(template)