darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix more skips

Browse Source
This commit is contained in:
Kenneth Kehl
2023-05-18 10:56:58 -07:00
parent 6e597aafad
commit d8c3b0dfe4
5 changed files with 7 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/app/celery/test_provider_tasks.py
View File

@@ -89,7 +89,6 @@ def test_should_retry_and_log_exception_for_non_SmsClientResponseException_excep
assert mock_logger_exception.called
@pytest.mark.skip(reason="Needs updating for TTS: Failing for unknown reason")
def test_should_go_into_technical_error_if_exceeds_retries_on_deliver_sms_task(sample_notification, mocker):
mocker.patch('app.delivery.send_to_providers.send_sms_to_provider', side_effect=Exception("EXPECTED"))
mocker.patch('app.celery.provider_tasks.deliver_sms.retry', side_effect=MaxRetriesExceededError())
@@ -128,7 +127,6 @@ def test_should_add_to_retry_queue_if_notification_not_found_in_deliver_email_ta
app.celery.provider_tasks.deliver_email.retry.assert_called_with(queue="retry-tasks")
@pytest.mark.skip(reason="Needs updating for TTS: Failing for unknown reason")
@pytest.mark.parametrize(
'exception_class', [
Exception(),
@@ -150,7 +148,6 @@ def test_should_go_into_technical_error_if_exceeds_retries_on_deliver_email_task
assert sample_notification.status == 'technical-failure'
@pytest.mark.skip(reason="Needs updating for TTS: Failing for unknown reason")
def test_should_technical_error_and_not_retry_if_EmailClientNonRetryableException(sample_notification, mocker):
mocker.patch(
'app.delivery.send_to_providers.send_email_to_provider',

7
tests/app/celery/test_reporting_tasks.py
View File

@@ -237,8 +237,7 @@ def test_create_nightly_billing_for_day_different_templates(
assert record.rate_multiplier == multiplier[i]
@pytest.mark.skip(reason="Needs updating for TTS: Timezone handling")
def test_create_nightly_billing_for_day_different_sent_by(
def test_create_nightly_billing_for_day_same_sent_by(
sample_service,
sample_template,
sample_email_template,
@@ -273,12 +272,12 @@ def test_create_nightly_billing_for_day_different_sent_by(
create_nightly_billing_for_day(str(yesterday.date()))
records = FactBilling.query.order_by('rate_multiplier').all()
assert len(records) == 2
assert len(records) == 1
for _, record in enumerate(records):
assert record.local_date == datetime.date(yesterday)
assert record.rate == Decimal(1.33)
assert record.billable_units == 1
assert record.billable_units == 2
assert record.rate_multiplier == 1.0