diff --git a/tests/app/conftest.py b/tests/app/conftest.py index b074ec7f9..fa17f3fd3 100644 --- a/tests/app/conftest.py +++ b/tests/app/conftest.py @@ -216,7 +216,7 @@ def sample_sms_code(notify_db_session): return code -@pytest.fixture(scope="session") +@pytest.fixture(scope="function") def sample_service(sample_user): service_name = "Sample service" email_from = service_name.lower().replace(" ", ".") diff --git a/tests/app/service/test_rest.py b/tests/app/service/test_rest.py index 7f138c286..0d60f3e8b 100644 --- a/tests/app/service/test_rest.py +++ b/tests/app/service/test_rest.py @@ -3134,12 +3134,12 @@ def test_update_service_sms_sender(client, notify_db_session): assert not resp_json["is_default"] -@pytest.mark.usefixtures("client", "sample_service") +@pytest.mark.usefixtures("client") @settings(max_examples=10) @pytest.mark.parametrize("client", [True], indirect=True) @given(sms_sender=st.text(min_size=0, max_size=50), is_default=st.booleans()) -def test_fuzz_update_service_sms_sender(client, sms_sender, is_default, sample_service): - service = sample_service +def test_fuzz_update_service_sms_sender(client, sms_sender, is_default): + service = create_service() service_sms_sender = create_service_sms_sender( service=service, sms_sender="1235", is_default=False ) @@ -3165,6 +3165,12 @@ def test_fuzz_update_service_sms_sender(client, sms_sender, is_default, sample_s assert resp_json["sms_sender"] == sms_sender assert resp_json["is_default"] == is_default + client.post( + "service.delete_service_sms_sender", + service_id=service.id, + sms_sender_id=service_sms_sender.id, + ) + def test_update_service_sms_sender_switches_default(client, notify_db_session): service = create_service_with_defined_sms_sender(sms_sender_value="first")