darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-24 00:06:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

remove autocommit and clean up some bad debug statements

Browse Source
This commit is contained in:
Kenneth Kehl
2023-06-27 13:06:38 -07:00
parent 17e9fc1e8f
commit d7ad65ef89
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/dao/notifications_dao.py
View File

@@ -271,7 +271,6 @@ def _filter_query(query, filter_dict=None):
return query return query
@autocommit
def sanitize_successful_notification_by_id( def sanitize_successful_notification_by_id(
notification_id notification_id
): ):
@@ -283,6 +282,7 @@ def sanitize_successful_notification_by_id(
{'to': phone_prefix, 'normalised_to': phone_prefix, 'status': 'delivered'}, {'to': phone_prefix, 'normalised_to': phone_prefix, 'status': 'delivered'},
synchronize_session=False synchronize_session=False
) )
db.session.commit()
@autocommit @autocommit

3
app/notifications/process_notifications.py
View File

@@ -121,8 +121,6 @@ def persist_notification(
updated_at=updated_at updated_at=updated_at
) )
current_app.logger.info('Persisting notification with to address: {}'.format(notification.to))
if notification_type == SMS_TYPE: if notification_type == SMS_TYPE:
formatted_recipient = validate_and_format_phone_number(recipient, international=True) formatted_recipient = validate_and_format_phone_number(recipient, international=True)
recipient_info = get_international_phone_info(formatted_recipient) recipient_info = get_international_phone_info(formatted_recipient)
@@ -133,7 +131,6 @@ def persist_notification(
elif notification_type == EMAIL_TYPE: elif notification_type == EMAIL_TYPE:
current_app.logger.info('Persisting notification with type: {}'.format(EMAIL_TYPE)) current_app.logger.info('Persisting notification with type: {}'.format(EMAIL_TYPE))
notification.normalised_to = format_email_address(notification.to) notification.normalised_to = format_email_address(notification.to)
current_app.logger.info('Persisting notification to formatted email: {}'.format(notification.normalised_to))
# if simulated create a Notification model to return but do not persist the Notification to the dB # if simulated create a Notification model to return but do not persist the Notification to the dB
if not simulated: if not simulated: