darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3348 from alphagov/better-callback-stats-180016688

Browse Source 
Include status in stats about delivery times
This commit is contained in:
Ben Thorner
2021-10-22 11:59:24 +01:00
committed by GitHub
parent 0b8c6ef263 f974108934
commit d703251b13
4 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/celery/process_ses_receipts_tasks.py
View File

@@ -70,7 +70,11 @@ def process_ses_results(self, response):
statsd_client.incr('callback.ses.{}'.format(notification_status)) statsd_client.incr('callback.ses.{}'.format(notification_status))
if notification.sent_at: if notification.sent_at:
statsd_client.timing_with_dates('callback.ses.elapsed-time', datetime.utcnow(), notification.sent_at) statsd_client.timing_with_dates(
f'callback.ses.{notification_status}.elapsed-time',
datetime.utcnow(),
notification.sent_at
)
_check_and_queue_callback_task(notification) _check_and_queue_callback_task(notification)

2
app/celery/process_sms_client_response_tasks.py
View File

@@ -75,7 +75,7 @@ def _process_for_status(notification_status, client_name, provider_reference, de
if notification.sent_at: if notification.sent_at:
statsd_client.timing_with_dates( statsd_client.timing_with_dates(
'callback.{}.elapsed-time'.format(client_name.lower()), f'callback.{client_name.lower()}.{notification_status}.elapsed-time',
datetime.utcnow(), datetime.utcnow(),
notification.sent_at notification.sent_at
) )

2
tests/app/celery/test_process_ses_receipts_tasks.py
View File

@@ -86,7 +86,7 @@ def test_ses_callback_should_update_notification_status(
assert process_ses_results(ses_notification_callback(reference='ref')) assert process_ses_results(ses_notification_callback(reference='ref'))
assert get_notification_by_id(notification.id).status == 'delivered' assert get_notification_by_id(notification.id).status == 'delivered'
statsd_client.timing_with_dates.assert_any_call( statsd_client.timing_with_dates.assert_any_call(
"callback.ses.elapsed-time", datetime.utcnow(), notification.sent_at "callback.ses.delivered.elapsed-time", datetime.utcnow(), notification.sent_at
) )
statsd_client.incr.assert_any_call("callback.ses.delivered") statsd_client.incr.assert_any_call("callback.ses.delivered")
updated_notification = Notification.query.get(notification.id) updated_notification = Notification.query.get(notification.id)

2
tests/app/notifications/test_process_client_response.py
View File

@@ -144,7 +144,7 @@ def test_process_sms_client_response_records_statsd_metrics(sample_notification,
statsd_client.incr.assert_any_call("callback.firetext.delivered") statsd_client.incr.assert_any_call("callback.firetext.delivered")
statsd_client.timing_with_dates.assert_any_call( statsd_client.timing_with_dates.assert_any_call(
"callback.firetext.elapsed-time", datetime.utcnow(), sample_notification.sent_at "callback.firetext.delivered.elapsed-time", datetime.utcnow(), sample_notification.sent_at
) )