darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-05 02:41:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Review Changes

Browse Source 
- Updated the retry and max_retries of the process_ses_results celery
task to be the same as other retry strategies in that file
- Provided a message with the 200 to be similar to how other responses
are handled
This commit is contained in:
Richard Chapman
2017-10-26 12:09:14 +01:00
parent c2f2d39d22
commit d6cff97b7b
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/celery/tasks.py
View File

@@ -550,7 +550,7 @@ def process_incomplete_job(job_id):
job_complete(job, job.service, template, resumed=True) job_complete(job, job.service, template, resumed=True)
@notify_celery.task(bind=True, name="process-ses-result", max_retries=12, default_retry_delay=300000) @notify_celery.task(bind=True, name="process-ses-result", max_retries=5, default_retry_delay=300)
@statsd(namespace="tasks") @statsd(namespace="tasks")
def process_ses_results(self, response): def process_ses_results(self, response):
errors = process_ses_response(response) errors = process_ses_response(response)

4
app/notifications/notifications_ses_callback.py
View File

@@ -32,7 +32,9 @@ def sns_callback_handler():
current_app.logger.error(errors) current_app.logger.error(errors)
raise InvalidRequest(errors, 400) raise InvalidRequest(errors, 400)
return 200 return jsonify(
result="success", message="SES callback succeeded"
), 200
def process_ses_response(ses_request): def process_ses_response(ses_request):