darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-15 07:18:09 -04:00
Code Issues Packages Projects Releases Wiki Activity

Another unused method to delete

Browse Source
This commit is contained in:
Rebecca Law
2018-03-02 11:02:54 +00:00
parent bffc4863db
commit d6c929d127
4 changed files with 2 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/app/celery/test_ftp_update_tasks.py
View File

@@ -19,7 +19,6 @@ from app.celery.tasks import (
check_billable_units,
process_updates_from_file,
update_dvla_job_to_error,
update_job_to_sent_to_dvla,
update_letter_notifications_statuses,
update_letter_notifications_to_error,
update_letter_notifications_to_sent_to_dvla
@@ -38,17 +37,6 @@ def notification_update():
return NotificationUpdate('REFERENCE_ABC', 'sent', '1', 'cost')
def test_update_job_to_sent_to_dvla(sample_letter_template, sample_letter_job):
create_notification(template=sample_letter_template, job=sample_letter_job)
create_notification(template=sample_letter_template, job=sample_letter_job)
update_job_to_sent_to_dvla(job_id=sample_letter_job.id)
updated_notifications = Notification.query.all()
assert [(n.status == 'sending', n.sent_by == 'dvla') for n in updated_notifications]
assert Job.query.filter_by(id=sample_letter_job.id).one().job_status == 'sent to dvla'
def test_update_dvla_job_to_error(sample_letter_template, sample_letter_job):
create_notification(template=sample_letter_template, job=sample_letter_job)
create_notification(template=sample_letter_template, job=sample_letter_job)

43
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -18,7 +18,6 @@ from app.dao.notifications_dao import (
dao_get_template_usage,
dao_timeout_notifications,
dao_update_notification,
dao_update_notifications_for_job_to_sent_to_dvla,
dao_update_notifications_by_reference,
delete_notifications_created_more_than_a_week_ago_by_type,
get_notification_by_id,
@@ -59,7 +58,6 @@ from tests.app.conftest import (
sample_letter_template
)
from tests.app.db import (
create_api_key,
create_job,
create_notification,
create_service,
@@ -1712,47 +1710,6 @@ def test_slow_provider_delivery_does_not_return_for_standard_delivery_time(
assert not slow_delivery
def test_dao_update_notifications_for_job_to_sent_to_dvla(notify_db, notify_db_session, sample_letter_template):
job = sample_job(notify_db=notify_db, notify_db_session=notify_db_session, template=sample_letter_template)
notification = create_notification(template=sample_letter_template, job=job)
updated_count = dao_update_notifications_for_job_to_sent_to_dvla(job_id=job.id, provider='some provider')
assert updated_count == 1
updated_notification = Notification.query.get(notification.id)
assert updated_notification.status == 'sending'
assert updated_notification.sent_by == 'some provider'
assert updated_notification.sent_at
assert updated_notification.updated_at
history = NotificationHistory.query.get(notification.id)
assert history.status == 'sending'
assert history.sent_by == 'some provider'
assert history.sent_at
assert history.updated_at
def test_dao_update_notifications_for_job_to_sent_to_dvla_does_update_history_if_test_key(sample_letter_job):
api_key = create_api_key(sample_letter_job.service, key_type=KEY_TYPE_TEST)
notification = create_notification(
sample_letter_job.template,
job=sample_letter_job,
api_key=api_key
)
updated_count = dao_update_notifications_for_job_to_sent_to_dvla(
job_id=sample_letter_job.id,
provider='some provider'
)
assert updated_count == 1
updated_notification = Notification.query.get(notification.id)
assert updated_notification.status == 'sending'
assert updated_notification.sent_by == 'some provider'
assert updated_notification.sent_at
assert updated_notification.updated_at
assert NotificationHistory.query.count() == 0
def test_dao_get_notifications_by_to_field(sample_template):
recipient_to_search_for = {