darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 13:38:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

remove letters from models

Browse Source
This commit is contained in:
stvnrlly
2023-02-28 14:33:01 -05:00
parent 63e288ae3e
commit d6633aea5c
11 changed files with 17 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/v2/notifications/test_get_notifications.py
View File

@@ -382,7 +382,7 @@ def test_get_all_notifications_filter_by_status_invalid_status(client, sample_no
assert len(json_response['errors']) == 1
assert json_response['errors'][0]['message'] == "status elephant is not one of [cancelled, created, sending, " \
"sent, delivered, pending, failed, technical-failure, temporary-failure, permanent-failure, " \
"pending-virus-check, validation-failed, virus-scan-failed, returned-letter]"
"pending-virus-check, validation-failed, virus-scan-failed]"
def test_get_all_notifications_filter_by_multiple_statuses(client, sample_template):

4
tests/app/v2/notifications/test_notification_schemas.py
View File

@@ -45,7 +45,7 @@ def test_get_notifications_request_invalid_statuses(
partial_error_status = "is not one of " \
"[cancelled, created, sending, sent, delivered, pending, failed, " \
"technical-failure, temporary-failure, permanent-failure, pending-virus-check, " \
"validation-failed, virus-scan-failed, returned-letter]"
"validation-failed, virus-scan-failed]"
with pytest.raises(ValidationError) as e:
validate({'status': invalid_statuses + valid_statuses}, get_notifications_request)
@@ -93,7 +93,7 @@ def test_get_notifications_request_invalid_statuses_and_template_types():
for invalid_status in ["elephant", "giraffe"]:
assert "status {} is not one of [cancelled, created, sending, sent, delivered, " \
"pending, failed, technical-failure, temporary-failure, permanent-failure, " \
"pending-virus-check, validation-failed, virus-scan-failed, returned-letter]".format(
"pending-virus-check, validation-failed, virus-scan-failed]".format(
invalid_status
) in error_messages

1
tests/app/v2/notifications/test_post_notifications.py
View File

@@ -357,7 +357,6 @@ def test_post_notification_returns_400_and_missing_template(client, sample_servi
@pytest.mark.parametrize("notification_type, key_send_to, send_to", [
("sms", "phone_number", "+447700900855"),
("email", "email_address", "sample@email.com"),
("letter", "personalisation", {"address_line_1": "The queen", "postcode": "SW1 1AA"})
])
def test_post_notification_returns_401_and_well_formed_auth_error(client, sample_template,
notification_type, key_send_to, send_to):