darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 23:55:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Normalize outbound SMS sender number in one off notifications

Browse Source
This commit is contained in:
Alexey Bezhan
2017-12-18 16:16:33 +00:00
parent 545ff7dda6
commit d5b6bd85fe
3 changed files with 58 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
tests/app/service/test_send_one_off_notification.py
View File

@@ -19,6 +19,7 @@ from tests.app.db import (
create_user,
create_reply_to_email,
create_letter_contact,
create_service_sms_sender,
create_service,
create_template
)
@@ -238,9 +239,62 @@ def test_send_one_off_letter_notification_should_use_template_reply_to_text(samp
research_mode=False,
queue=None
)
assert notification.reply_to_text == "Edinburgh, ED1 1AA"
def test_send_one_off_sms_notification_should_use_sms_sender_reply_to_text(sample_service, celery_mock):
template = create_template(service=sample_service, template_type=SMS_TYPE)
sms_sender = create_service_sms_sender(
service=sample_service,
sms_sender='07123123123',
is_default=False
)
data = {
'to': '07111111111',
'template_id': str(template.id),
'created_by': str(sample_service.created_by_id),
'sender_id': str(sms_sender.id),
}
notification_id = send_one_off_notification(service_id=sample_service.id, post_data=data)
notification = Notification.query.get(notification_id['id'])
celery_mock.assert_called_once_with(
notification=notification,
research_mode=False,
queue=None
)
assert notification.reply_to_text == "447123123123"
def test_send_one_off_sms_notification_should_use_default_service_reply_to_text(sample_service, celery_mock):
template = create_template(service=sample_service, template_type=SMS_TYPE)
sample_service.service_sms_senders[0].is_default = False
create_service_sms_sender(
service=sample_service,
sms_sender='07123123456',
is_default=True
)
data = {
'to': '07111111111',
'template_id': str(template.id),
'created_by': str(sample_service.created_by_id),
}
notification_id = send_one_off_notification(service_id=sample_service.id, post_data=data)
notification = Notification.query.get(notification_id['id'])
celery_mock.assert_called_once_with(
notification=notification,
research_mode=False,
queue=None
)
assert notification.reply_to_text == "447123123456"
def test_send_one_off_notification_should_throw_exception_if_reply_to_id_doesnot_exist(
sample_email_template
):