darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-07-31 11:48:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Normalize outbound SMS sender number in one off notifications

Browse Source
This commit is contained in:
Alexey Bezhan
2017-12-18 16:16:33 +00:00
parent 545ff7dda6
commit d5b6bd85fe
3 changed files with 58 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/models.py
View File

@@ -367,6 +367,9 @@ class ServiceSmsSender(db.Model):
created_at = db.Column(db.DateTime, default=datetime.datetime.utcnow, nullable=False)
updated_at = db.Column(db.DateTime, nullable=True, onupdate=datetime.datetime.utcnow)
def get_reply_to_text(self):
return try_validate_and_format_phone_number(self.sms_sender)
def serialize(self):
return {
"id": str(self.id),

2
app/service/send_notification.py
View File

@@ -90,7 +90,7 @@ def get_reply_to_text(notification_type, sender_id, service, template):
if notification_type == EMAIL_TYPE:
reply_to = dao_get_reply_to_by_id(service.id, sender_id).email_address
elif notification_type == SMS_TYPE:
reply_to = dao_get_service_sms_senders_by_id(service.id, sender_id).sms_sender
reply_to = dao_get_service_sms_senders_by_id(service.id, sender_id).get_reply_to_text()
else:
reply_to = template.get_reply_to_text()