darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3072 from alphagov/doc-dl-exc

Browse Source 
handle doc dl connection errors correctly
This commit is contained in:
Leo Hemsted
2020-12-31 11:24:00 +00:00
committed by GitHub
parent 8834377a5d 325f271e25
commit d470c928cd
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/app/clients/test_document_download.py
View File

@@ -1,3 +1,4 @@
import requests
import requests_mock
import pytest
@@ -56,3 +57,16 @@ def test_should_raise_non_400_statuses_as_exceptions(document_download):
assert type(excinfo.value) == Exception # make sure it's a base exception, so will be handled as a 500 by v2 api
assert str(excinfo.value) == 'Unhandled document download error: {"error": "Auth Error Of Some Kind"}'
def test_should_raise_exceptions_without_http_response_bodies_as_exceptions(document_download):
with pytest.raises(Exception) as excinfo, requests_mock.Mocker() as request_mock:
request_mock.post(
'https://document-download/services/service-id/documents',
exc=requests.exceptions.ConnectTimeout
)
document_download.upload_document('service-id', 'abababab')
assert type(excinfo.value) == Exception # make sure it's a base exception, so will be handled as a 500 by v2 api
assert str(excinfo.value) == 'Unhandled document download error: ConnectTimeout()'