Changed reported_at to a date and included audit columns.

This commit is contained in:
Rebecca Law
2019-12-12 14:11:54 +00:00
parent 140cb65554
commit d330025447
5 changed files with 24 additions and 14 deletions

View File

@@ -1,4 +1,4 @@
from datetime import datetime, timedelta
from datetime import datetime, timedelta, date
from freezegun import freeze_time
@@ -37,16 +37,19 @@ def test_insert_or_update_returned_letters_updates(sample_letter_template):
returned_letters = ReturnedLetter.query.all()
assert len(returned_letters) == 2
for x in returned_letters:
assert x.reported_at == datetime(2019, 12, 9, 13, 30)
assert x.reported_at == date(2019, 12, 9)
assert x.created_at == datetime(2019, 12, 9, 13, 30)
assert not x.updated_at
assert x.notification_id in [notification.id, history.id]
with freeze_time('2019-12-10 14:20'):
insert_or_update_returned_letters(['ref1', 'ref2'])
returned_letters = ReturnedLetter.query.all()
assert len(returned_letters) == 2
for x in returned_letters:
assert x.reported_at == datetime(2019, 12, 10, 14, 20)
assert x.reported_at == date(2019, 12, 10)
assert x.created_at == datetime(2019, 12, 9, 13, 30)
assert x.updated_at == datetime(2019, 12, 10, 14, 20)
assert x.notification_id in [notification.id, history.id]
@@ -93,7 +96,7 @@ def test_get_returned_letter_summary(sample_service):
assert len(results) == 1
assert results[0].returned_letter_count == 2
assert results[0].reported_at == now
assert results[0].reported_at == now.date()
def test_get_returned_letter_summary_orders_by_reported_at(sample_service):
@@ -109,7 +112,7 @@ def test_get_returned_letter_summary_orders_by_reported_at(sample_service):
results = get_returned_letter_summary(sample_service.id)
assert len(results) == 2
assert results[0].reported_at == now
assert results[0].reported_at == now.date()
assert results[0].returned_letter_count == 3
assert results[1].reported_at == last_month
assert results[1].reported_at == last_month.date()
assert results[1].returned_letter_count == 2

View File

@@ -952,7 +952,8 @@ def create_returned_letter(service=None, reported_at=None):
returned_letter = ReturnedLetter(
service_id=service.id,
reported_at=reported_at or datetime.utcnow(),
notification_id=notification.id
notification_id=notification.id,
created_at=datetime.utcnow(),
)
db.session.add(returned_letter)