darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-15 01:32:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1330 from GSA/fix_test_coverage

Browse Source 
actually start deleting old s3 objects
This commit is contained in:
Kenneth Kehl
2024-09-26 08:13:20 -07:00
committed by GitHub
parent 0736c982f0 564ae06383
commit d27d877f68
4 changed files with 28 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/aws/s3.py
View File

@@ -87,7 +87,6 @@ def get_bucket_name():
def cleanup_old_s3_objects():
bucket_name = get_bucket_name()
s3_client = get_s3_client()
@@ -99,9 +98,15 @@ def cleanup_old_s3_objects():
while True:
for obj in response.get("Contents", []):
if obj["LastModified"] <= time_limit:
current_app.logger.info(
f"#delete-old-s3-objects Wanting to delete: {obj['LastModified']} {obj['Key']}"
)
try:
remove_csv_object(obj["Key"])
current_app.logger.info(
f"#delete-old-s3-objects Deleted: {obj['LastModified']} {obj['Key']}"
)
except botocore.exceptions.ClientError:
current_app.logger.exception(f"Couldn't delete {obj['Key']}")
if "NextContinuationToken" in response:
response = s3_client.list_objects_v2(
Bucket=bucket_name,