darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-21 07:51:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make sure we don't log the phone number

Browse Source
This commit is contained in:
Rebecca Law
2017-07-12 15:32:59 +01:00
parent 6fb4e16067
commit d18ce47114
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/notifications/notifications_sms_callback.py
View File

@@ -24,9 +24,11 @@ def process_mmg_response():
reference=data.get('CID'), reference=data.get('CID'),
client_name=client_name) client_name=client_name)
safe_to_log = data.copy()
safe_to_log.pop("MSISDN")
current_app.logger.info( current_app.logger.info(
"Full delivery response from {} for notification: {}\n{}".format(client_name, request.form.get('reference'), "Full delivery response from {} for notification: {}\n{}".format(client_name, request.form.get('CID'),
request.form)) safe_to_log))
if errors: if errors:
raise InvalidRequest(errors, status_code=400) raise InvalidRequest(errors, status_code=400)
else: else:
@@ -41,12 +43,12 @@ def process_firetext_response():
client_name=client_name) client_name=client_name)
if errors: if errors:
raise InvalidRequest(errors, status_code=400) raise InvalidRequest(errors, status_code=400)
safe_to_log = dict(request.form).copy()
status = request.form.get('status') safe_to_log.pop('mobile')
current_app.logger.info( current_app.logger.info(
"Full delivery response from {} for notification: {}\n{}".format(client_name, request.form.get('reference'), "Full delivery response from {} for notification: {}\n{}".format(client_name, request.form.get('reference'),
request.form)) safe_to_log))
success, errors = process_sms_client_response(status=status, success, errors = process_sms_client_response(status=request.form.get('status'),
reference=request.form.get('reference'), reference=request.form.get('reference'),
client_name=client_name) client_name=client_name)
if errors: if errors: