darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

DRY-up pre-existing method to get PDF body/meta

Browse Source 
This is possible now that the "find_..." method returns an S3 object.
This commit is contained in:
Ben Thorner
2021-03-16 12:35:56 +00:00
parent c76e789f1e
commit d17a6c8dbe
1 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/letters/utils.py
View File

@@ -186,16 +186,7 @@ def get_file_names_from_error_bucket():
def get_letter_pdf_and_metadata(notification): def get_letter_pdf_and_metadata(notification):
bucket_name, prefix = get_bucket_name_and_prefix_for_notification(notification) obj = find_letter_pdf_in_s3(notification).get()
s3 = boto3.resource('s3')
bucket = s3.Bucket(bucket_name)
item = next(x for x in bucket.objects.filter(Prefix=prefix))
obj = s3.Object(
bucket_name=bucket_name,
key=item.key
).get()
return obj["Body"].read(), obj["Metadata"] return obj["Body"].read(), obj["Metadata"]