darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add uncovered test cases

Browse Source 
We want to know that the overlay is added regardless of which page
number you are requesting when a pdf contains pages that go beyond the
print area
This commit is contained in:
David McDonald
2020-03-09 13:35:00 +00:00
parent 851435701f
commit d168dd106e
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/app/template/test_rest.py
View File

@@ -1143,11 +1143,13 @@ def test_preview_letter_template_precompiled_s3_error(
@pytest.mark.parametrize( @pytest.mark.parametrize(
"filetype, post_url, message", "filetype, post_url, message, requested_page",
[ [
('png', 'precompiled-preview.png', ""), ('png', 'precompiled-preview.png', "", ""),
('png', 'precompiled/overlay.png?page_number=1', "content-outside-printable-area"), ('png', 'precompiled/overlay.png?page_number=1', "content-outside-printable-area", "1"),
('pdf', 'precompiled/overlay.pdf', "content-outside-printable-area") ('png', 'precompiled/overlay.png?page_number=2', "content-outside-printable-area", "2"),
('png', 'precompiled/overlay.png?page_number=3', "content-outside-printable-area", "3"),
('pdf', 'precompiled/overlay.pdf', "content-outside-printable-area", "")
] ]
) )
def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay( def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay(
@@ -1158,7 +1160,8 @@ def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay(
mocker, mocker,
filetype, filetype,
post_url, post_url,
message message,
requested_page,
): ):
template = create_template(sample_service, template = create_template(sample_service,
@@ -1180,8 +1183,8 @@ def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay(
metadata = { metadata = {
"message": message, "message": message,
"invalid_pages": "[1]", "invalid_pages": "[1,3]",
"page_count": "1" "page_count": "4"
} }
mock_get_letter_pdf = mocker.patch( mock_get_letter_pdf = mocker.patch(
@@ -1194,12 +1197,13 @@ def test_preview_letter_template_precompiled_png_file_type_or_pdf_with_overlay(
mock_post = request_mock.post( mock_post = request_mock.post(
'http://localhost/notifications-template-preview/{}'.format(post_url), 'http://localhost/notifications-template-preview/{}'.format(post_url),
content=expected_returned_content, content=expected_returned_content,
headers={'X-pdf-page-count': '1'}, headers={'X-pdf-page-count': '4'},
status_code=200 status_code=200
) )
response = admin_request.get( response = admin_request.get(
'template.preview_letter_template_by_notification_id', 'template.preview_letter_template_by_notification_id',
page=requested_page,
service_id=notification.service_id, service_id=notification.service_id,
notification_id=notification.id, notification_id=notification.id,
file_type=filetype, file_type=filetype,