mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-17 10:42:25 -05:00
CC DVLA in tickets about outstanding letters
Previously we sent them emails about this manually. We also tried a Zendesk macro/trigger approach, but using a CC means: - We can control the behaviour ourselves (Zendesk triggers can only be edited by admins outside our team). - We keep the DVLA notification approach consistent and in one place, so notifications always go to the same people. - Any further (public) updates to the ticket will also trigger a notification to DVLA (previous trigger only notified on creation).
This commit is contained in:
@@ -185,6 +185,7 @@ def raise_alert_if_letter_notifications_still_sending():
|
|||||||
|
|
||||||
ticket = NotifySupportTicket(
|
ticket = NotifySupportTicket(
|
||||||
subject=f"[{current_app.config['NOTIFY_ENVIRONMENT']}] Letters still sending",
|
subject=f"[{current_app.config['NOTIFY_ENVIRONMENT']}] Letters still sending",
|
||||||
|
email_ccs=current_app.config['DVLA_EMAIL_ADDRESSES'],
|
||||||
message=message,
|
message=message,
|
||||||
ticket_type=NotifySupportTicket.TYPE_INCIDENT,
|
ticket_type=NotifySupportTicket.TYPE_INCIDENT,
|
||||||
technical_ticket=True,
|
technical_ticket=True,
|
||||||
|
|||||||
@@ -250,6 +250,7 @@ def test_create_ticket_if_letter_notifications_still_sending(notify_api, mocker)
|
|||||||
mock_create_ticket.assert_called_once_with(
|
mock_create_ticket.assert_called_once_with(
|
||||||
ANY,
|
ANY,
|
||||||
subject='[test] Letters still sending',
|
subject='[test] Letters still sending',
|
||||||
|
email_ccs=current_app.config['DVLA_EMAIL_ADDRESSES'],
|
||||||
message=(
|
message=(
|
||||||
"There are 1 letters in the 'sending' state from Monday 15 January. Resolve using "
|
"There are 1 letters in the 'sending' state from Monday 15 January. Resolve using "
|
||||||
"https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#deal-with-letters-still-in-sending"
|
"https://github.com/alphagov/notifications-manuals/wiki/Support-Runbook#deal-with-letters-still-in-sending"
|
||||||
|
|||||||
Reference in New Issue
Block a user