darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug where the content header was not being passed onto the post

Browse Source 
request. Changed data => json.

Added extra logging to display the error with more detail
This commit is contained in:
Richard Chapman
2018-03-06 14:24:30 +00:00
parent bfdd385ba3
commit d0df85a602
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
app/template/rest.py
View File

@@ -205,8 +205,9 @@ def preview_letter_template_by_notification_id(service_id, notification_id, file
pdf_file = get_letter_pdf(notification) pdf_file = get_letter_pdf(notification)
except botocore.exceptions.ClientError: except botocore.exceptions.ClientError as e:
current_app.logger.info current_app.logger.exception(
'Error getting letter file from S3 notification id {}'.format(notification_id), e)
raise InvalidRequest('Error getting letter file from S3 notification id {}'.format(notification_id), raise InvalidRequest('Error getting letter file from S3 notification id {}'.format(notification_id),
status_code=500) status_code=500)
@@ -253,13 +254,23 @@ def preview_letter_template_by_notification_id(service_id, notification_id, file
def _get_png_preview(url, data, notification_id): def _get_png_preview(url, data, notification_id):
resp = requests_post( resp = requests_post(
url, url,
data=data, json=data,
headers={'Authorization': 'Token {}'.format(current_app.config['TEMPLATE_PREVIEW_API_KEY'])} headers={'Authorization': 'Token {}'.format(current_app.config['TEMPLATE_PREVIEW_API_KEY'])}
) )
if resp.status_code != 200: if resp.status_code != 200:
current_app.logger.exception(
'Error generating preview letter for {} \nStatus code: {}\n{}'.format(
notification_id,
resp.status_code,
resp.content
))
raise InvalidRequest( raise InvalidRequest(
'Error generating preview for {}'.format(notification_id), status_code=500 'Error generating preview letter for {} \nStatus code: {}\n{}'.format(
notification_id,
resp.status_code,
resp.content
), status_code=500
) )
return base64.b64encode(resp.content).decode('utf-8') return base64.b64encode(resp.content).decode('utf-8')