darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Added flag to remove default sender from user list"

Browse Source
This commit is contained in:
Andrew Shumway
2023-11-06 11:49:17 -07:00
committed by GitHub
parent 9cdc507f6c
commit d0368695db
5 changed files with 7 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/dao/services_dao.py
View File

@@ -273,7 +273,6 @@ def dao_create_service(
user,
service_id=None,
service_permissions=None,
create_default_sms_sender=False,
):
if not user:
raise ValueError("Can't create a service without a user")
@@ -298,11 +297,8 @@ def dao_create_service(
)
service.permissions.append(service_permission)
# We are removing an sms default sender from being added to each
# service as it is created, but we will pass a default flag
# because some tests need a default number.
if create_default_sms_sender:
insert_service_sms_sender(service, current_app.config["FROM_NUMBER"])
# do we just add the default - or will we get a value from FE?
insert_service_sms_sender(service, current_app.config["FROM_NUMBER"])
if organization:
service.organization_id = organization.id