From 7a6d748c6ab99cd91cd071071c2b7960e0f87c6d Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 6 Apr 2017 13:12:05 +0100 Subject: [PATCH] Build DVLA file with blank `TO_NAME_2` field MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem: we were sending the first line of the address in the `TO_NAME_2` field. This meant that they couldn’t do any PAF lookups with it, because it wasn’t where they were expecting. The first line of the address is the second line of what our users give us. We need to give this to DVLA as the _third_ line of the address output, which they call `TO_ADDRESS_LINE_1`. --- requirements.txt | 2 +- tests/app/celery/test_tasks.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/requirements.txt b/requirements.txt index 98b9ef1da..f047a5d05 100644 --- a/requirements.txt +++ b/requirements.txt @@ -29,6 +29,6 @@ notifications-python-client>=3.1,<3.2 awscli>=1.11,<1.12 awscli-cwlogs>=1.4,<1.5 -git+https://github.com/alphagov/notifications-utils.git@15.0.0#egg=notifications-utils==15.0.0 +git+https://github.com/alphagov/notifications-utils.git@15.0.2#egg=notifications-utils==15.0.2 git+https://github.com/alphagov/boto.git@2.43.0-patch3#egg=boto==2.43.0-patch3 diff --git a/tests/app/celery/test_tasks.py b/tests/app/celery/test_tasks.py index 7a410bc60..508c9e0d0 100644 --- a/tests/app/celery/test_tasks.py +++ b/tests/app/celery/test_tasks.py @@ -1018,4 +1018,4 @@ def test_dvla_letter_template(sample_letter_notification): letter = LetterDVLATemplate(t, sample_letter_notification.personalisation, 12345) - assert str(letter) == "140|500|001||201703230012345|||||||||||||A1|A2|A3|A4|A5|A6||A_POST|||||||||23 March 2017

Template subjectDear Sir/Madam, Hello. Yours Truly, The Government." # noqa + assert str(letter) == "140|500|001||201703230012345|||||||||||||A1||A2|A3|A4|A5|A6|A_POST|||||||||23 March 2017

Template subjectDear Sir/Madam, Hello. Yours Truly, The Government." # noqa